-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: network upgrade transactions for cgt #17062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package derive | ||
|
||
import ( | ||
"github.com/ethereum/go-ethereum/common/hexutil" | ||
) | ||
|
||
// CustomGasTokenNetworkUpgradeTransactions returns the transactions required to upgrade to use a custom gas token. | ||
// For now, this function returns an empty slice of transactions as requested. | ||
func CustomGasTokenNetworkUpgradeTransactions() ([]hexutil.Bytes, error) { | ||
// TODO: Implement custom gas token upgrade transactions | ||
// Deploy controller, liquidity, set implementations, mint ETH to liquidity | ||
upgradeTxns := make([]hexutil.Bytes, 0) | ||
return upgradeTxns, nil | ||
} | ||
Comment on lines
+9
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High severity: Incomplete Custom Gas Token Upgrade Implementation Description: Recommendation:
Don't like this finding? Reply "dismiss" and it won't appear again in future scans. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package derive | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestCustomGasTokenNetworkTransactions(t *testing.T) { | ||
upgradeTxns, err := CustomGasTokenNetworkUpgradeTransactions() | ||
require.NoError(t, err) | ||
// For now, the function returns an empty slice as requested | ||
require.Len(t, upgradeTxns, 0) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly sure how to feature flag the best way, this cgt fork should be temporary