-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: introduce fee splitter for revenue share #17536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xDiscotech
wants to merge
29
commits into
ethereum-optimism:develop
Choose a base branch
from
defi-wonderland:sc-feat/fee-splitter-system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: introduce fee splitter for revenue share #17536
0xDiscotech
wants to merge
29
commits into
ethereum-optimism:develop
from
defi-wonderland:sc-feat/fee-splitter-system
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---- Co-authored-by: Disco <[email protected]> Co-authored-by: Flux <[email protected]> Co-authored-by: Chiin <[email protected]>
chore: sync last develop
tynes
reviewed
Sep 26, 2025
tynes
reviewed
Sep 26, 2025
JosepBove
reviewed
Oct 7, 2025
JosepBove
reviewed
Oct 7, 2025
JosepBove
reviewed
Oct 7, 2025
JosepBove
reviewed
Oct 7, 2025
As I mentioned on our chats, everything LGTM. Just this minor spec mismatch-related stuff. |
JosepBove
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce the
FeeSplitter
predeploy as part of a new revenue-sharing feature. The goal is to make revenue sharing simpler and more modular, with configurable values and automated handling where possible.Includes supporting contracts like
SuperchainRevSharesCalculator
,L1Withdrawer
, andFeesDepositor
, which act as periphery components of the system and cover the first expected use case.This is opt-in, but will be enabled by default on fresh chains at genesis. Operators must set a chain fees recipient address on L2 for splits to work.
FeeVaults
were updated to be more flexible with setters, while keeping backwards compatibility.Tests
Additional context
Metadata
When the
FeesDepositor
contract for OP’s L1 fees is deployed, it should be linked here