op-dispute-mon: node endpoint error metrics #17622
Open
+1,726
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldowman
changed the title
Inphi
reviewed
Sep 30, 2025
|
|
||
| // HasMixedSafety returns true if some rollup endpoints reported the root as safe and others as unsafe | ||
| // for this game. This indicates inconsistent safety assessment across the rollup node network. | ||
| func (g EnrichedGameData) HasMixedSafety() bool { |
There was a problem hiding this comment.
Was this supposed to be recorded in a metric? I only see this function used by tests.
| RollupEndpointUnsafeCount int | ||
|
|
||
| // RollupEndpointDifferentOutputRoots tracks whether rollup endpoints returned different output roots for this game. | ||
| RollupEndpointDifferentOutputRoots bool |
There was a problem hiding this comment.
There's no way to observe the value of this field. I don't see a log or a metric set when this is updated.
| uniqueEndpointErrors := make(map[string]bool) | ||
|
|
||
| for _, game := range games { | ||
| if game.RollupEndpointErrors != nil { |
There was a problem hiding this comment.
Suggested change
| if game.RollupEndpointErrors != nil { | |
| if len(game.RollupEndpointErrors) != 0 { |
since the map is always initialized in enrichGame. Also, it's idiomatic to use len for emptiness because it also works when the map is nil.
| "unique_endpoint_count", errorCount, | ||
| "endpoints", getEndpointList(uniqueEndpointErrors)) | ||
| } else { | ||
| m.logger.Debug("No rollup node endpoint errors found") |
There was a problem hiding this comment.
nit: possibly noisy debug. Could use Trace instead.
| "total_error_count", totalErrors, | ||
| "games_with_errors", countGamesWithErrors(games)) | ||
| } else { | ||
| m.logger.Debug("No rollup node endpoint errors found") |
There was a problem hiding this comment.
nit: Noisy debug. Consider using Trace
| m.metrics.RecordMixedAvailabilityGames(count) | ||
|
|
||
| if count > 0 { | ||
| m.logger.Info("Mixed availability summary", "gamesWithMixedAvailability", count, "totalGames", len(games)) |
There was a problem hiding this comment.
worth logging this as a Warn. It's far from ideal when this occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following prometheus metrics to dispute-mon:
Reviewers might want to look at each commit separately, there's one for each metric.
Closes #11020