support arm devnet #17625
Open
support arm devnet #17625
+3,408
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FineKe
commented
Sep 26, 2025
FineKe
commented
- change l1 with arm64 docker image
update .gitignore to ignore additional test files and directories
* update * support op conductor * update readme * update readme * docs(test): fix comments * test(conductor): optimize stop leader script
* update * support op conductor * update readme * update readme * docs(test): fix comments * test(conductor): optimize stop leader script * chore(test): tidy up test scripts * chore(op-geth): use dev branch of op-geth * update * update op-geth
* feat(scripts): support rootless docker in 3-op-init.sh * feat(scripts): rename scripts for consistency * fix(scripts): fix rootless docker command * refactor(scrits): rename script name for consistency
Co-authored-by: weixie.cui <[email protected]>
* feat(test): customize seq parameters to support including more txs in a block * feat(test): support deposit from l1 to l2 * feat(test): support deposit from l1 to l2
Co-authored-by: weixie.cui <[email protected]>
Co-authored-by: weixie.cui <[email protected]>
* feat(test): use custom parent hash and fund large balance to a test account * feat(test): add test script * chore(test): tidy up unused files
* Add cursor rules * Fix db
* WIP: initial commit of e2e files from old repo * WIP: wip commit before moving e2e tests to op-geth * wip: commented out old tests * wip: change init file, docker compose and remove irrelevant tests * chore: add files to gitignore * fix: remove unnecessary cache pruning to optimise workflow * chore: remove e2e code that is now ported to op-geth * fix: pull branch to tmp directory & retry for leader detection * fix: echo test success after cleanup for clearer message * chore: cleanup makefile and always build op_geth * chore: remove unnecessary commit of transactor.sol * fix: add OP_GETH_LOCAL_DIRECTORY variable in .env file for developers to specify local op-geth directory * fix: run tests according to whether branch or local directory is specified * fix: run-test target local directory fix * chore: silence run-test target * fix: docker compose down only if .env file is present * chore: remove hardcoded values for env variables * fix: bugfix empty op_geth_image_tag * fix: reset op_geth_image_tag from example.env when building with submodule * fix * chore: make skipping op-stack and op-contracts env flags, clean up makefile * fix: revert unneccessary conductor retries * fix: remove tag changing logic * fix: change ports in docker compose
* add binary checks during image build & add flag of optional building op-geth in .env & update submodule op-geth commit id * update * update
* add gray upgrade simulation for op-conductor * update
…g files (#33) * Shift seq and rpc configs into geth config file * Use local submodule versions * Revert contracts * Fix * Optimize docker build with build cache mounts * Add cache path * Fix
* Update config files * Fix
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
| @@ -28,7 +28,7 @@ func Main(version string) cliapp.LifecycleAction { | |||
| oplog.SetGlobalLogHandler(l.Handler()) | |||
| opservice.ValidateEnvVars(flags.EnvVarPrefix, flags.Flags, l) | |||
|
|
|||
| l.Info("Initializing L2Output Submitter") | |||
| l.Info("Initializing L2Output Submitter", "cfg", cfg) | |||
There was a problem hiding this comment.
🟠 High severity: Sensitive Private Key Logged in Proposer Startup
Description:
The l.Info("Initializing L2Output Submitter", "cfg", cfg) call logs the entire CLI configuration (cfg), which includes sensitive fields such as the transaction manager private key, to application logs.
Recommendation:
Remove or sanitize the cfg argument when logging to avoid leaking secrets. Log only non-sensitive info or mask private key values.
Suggested change
| l.Info("Initializing L2Output Submitter", "cfg", cfg) | |
| l.Info("Initializing L2Output Submitter") |
Don't like this finding? Reply "dismiss" and it won't appear again in future scans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.