feat(op-conductor): rollup-boost partial unhealthiness tolerance

[yashvardhan-kukreja]

Description

Allows setting up two optional flags to op-conductor which allow conductor to tolerate 206's returned by rollup-boost. This feature is developed in favor of the fact that a lot of times such issues are bearable and not worth the leadership switch.

Tests

Additional context

Metadata

[jelias2]

I was thinking this type of feature could use the sliding_window from proxyd. What are your thoughts on re-using instead of making a new object for this?

That package already has testing and has been productionized already so I'd lean towards that over developing new modules.

[yashvardhan-kukreja]

I was thinking this type of feature could use the sliding_window from proxyd.

You mean importing proxyd as a package, and using? Although I haven't explored that thing but still I am not sure about establishing such kind of dependency b/w these two, especially considering that the dependent is gonna be op-conductor which is a part of optimism package.

If we'd like to re-use such functionality, I'd rather have it modularized somewhere under optimism like in op-service and have both proxyd and op-conductor import and use it. But I'd suggest having a different PR for it.

[jelias2]

Could the timeBoundedRotatingCounter be put into a subpackage and unit tested outside of the context of the partial health check as well?

[jelias2]

I was thinking this type of feature could use the sliding_window from proxyd.

You mean importing proxyd as a package, and using? Although I haven't explored that thing but still I am not sure about establishing such kind of dependency b/w these two, especially considering that the dependent is gonna be op-conductor which is a part of optimism package.

If we'd like to re-use such functionality, I'd rather have it modularized somewhere under optimism like in op-service and have both proxyd and op-conductor import and use it. But I'd suggest having a different PR for it.

Yeah your right, we would have circular dependencys, probably not the best idea

[yashvardhan-kukreja]

Could the timeBoundedRotatingCounter be put into a subpackage and unit tested outside of the context of the partial health check as well?

Done