feat(op-deployer): bootstrap, genesis and genesis override tests #17663
+376
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseguy
reviewed
Sep 30, 2025
| // TestEndToEndBootstrapApply tests that a system can be fully bootstrapped and applied, both from | ||
| // local artifacts and the default tagged artifacts. The tagged artifacts test only runs on proposal | ||
| // or backports branches, since those are the only branches with an SLA to support tagged artifacts. | ||
| func TestEndToEndBootstrapApply(t *testing.T) { |
There was a problem hiding this comment.
This seems like a duplicate of the /integration_test/apply_test.go TestEndToEndBootstrapApply. I think we need to trigger bootstrap via the cli runner instead of via the library function to include cli flag parsing in the test. Otherwise I'm not sure what value this test is adding compared to the existing one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds bootstrap, genesis and genesis override tests.
Tests
Additional context
Metadata