Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rollback update #405

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: rollback update #405

wants to merge 10 commits into from

Conversation

0xng
Copy link
Contributor

@0xng 0xng commented Oct 1, 2024

Description

This PR aims to update the message rollback implementation in the L2ToL2CrossDomainMessenger to match new practices.

Additional Questions

There's a necessity to have a way for relayExpire to know that the message not only originated from L2ToL2CrossDomainMessenger, but that it also originated within sendExpire. This is to avoid someone from expiring arbitrary hashes by calling sendMessage in the L2ToL2CrossDomainMessenger and then relaying the message to relayExpire. A way to do this is by setting the sender in sendExpire to an impossible account. I chose the L2ToL2CrossDomainMessenger address itself.

I was wondering whether a random account would be better, like 0xdead. My worry comes because this allows the path where the message created in sendExpire is not sent to relayExpire but to relayMessage, which would set the sender to the L2ToL2CrossDomainMessenger, and perhaps this could mess with contracts integrating with it.

@0xng 0xng requested a review from tynes as a code owner October 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants