sep/026: Add task to fix sepolia fp upgrade #421
Draft
+356
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
5322598 to
0e47db0
Compare
sebastianst
commented
Dec 17, 2024
sebastianst
commented
Dec 17, 2024
|
fyi the 025 task number is used and now executed by #410 |
mds1
reviewed
Dec 18, 2024
mds1
reviewed
Dec 18, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
0e47db0 to
4687d2b
Compare
sebastianst
changed the title
sebastianst
changed the title
Ethnical
reviewed
Dec 18, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
3141303 to
7a83426
Compare
mds1
reviewed
Dec 18, 2024
mds1
reviewed
Dec 18, 2024
mds1
previously approved these changes
Dec 18, 2024
Ethnical
reviewed
Dec 19, 2024
Ethnical
reviewed
Dec 19, 2024
Ethnical
reviewed
Dec 19, 2024
sebastianst
added a commit
that referenced
this pull request
Dec 19, 2024
Developed in #421 and now split into its own PR.
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
28cb383 to
8eb2621
Compare
geoknee
pushed a commit
that referenced
this pull request
Dec 19, 2024
Developed in #421 and now split into its own PR.
sebastianst
changed the title
|
Going to switch the FDG and PDG implementations to new MT-variants that @mbaxter deployed
|
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
8eb2621 to
98b9fa0
Compare
Inphi
previously approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
98b9fa0 to
28e82b3
Compare
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
28e82b3 to
e319959
Compare
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
e319959 to
8e8068b
Compare
auto-merge was automatically disabled
January 6, 2025 11:36
Merge commits are not allowed on this repository
Ethnical
reviewed
Jan 7, 2025
| FOUNDATION_SAFE=0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B | ||
| OWNER_SAFE=0x1Eb2fFc903729a0F03966B917003800b145F56E2 | ||
| SAFE_NONCE="" | ||
| SIMULATE_WITHOUT_LEDGER=0 # 1 |
There was a problem hiding this comment.
This is causing issue with the justfile since the justfile is checking only if the SIMULATE_WITHOUT_LEDGER is set and not the value of the var.
So during simulation this is going to work but when the signers will have to sign this will cause issue and will require to remove this value from the env file.
cf: #448
Ethnical
reviewed
Jan 7, 2025
| constructor() | ||
| SuperchainRegistry("sepolia", "op", "v1.8.0-rc.4") | ||
| DisputeGameUpgrade( | ||
| 0x03b7eaa4e3cbce90381921a4b48008f4769871d64f93d113fcadca08ecee503b, // absolutePrestate |
There was a problem hiding this comment.
I have verified against the MT FDG. https://sepolia.etherscan.io/address/0x833a817eF459f4eCdB83Fc5A4Bf04d09A4e83f3F#readContract
But I don't know if there is another place to get the information from?
Ethnical
reviewed
Jan 7, 2025
| ### `0x05F9613aDB30026FFd634f38e5C4dFd30a197Fa1` (`DisputeGameFactoryProxy`) | ||
|
|
||
| - **Key**: `0xffdfc1249c027f9191656349feb0761381bb32c9f557e01f419fd08754bf5a1b` <br/> | ||
| **Before**: `0x0000000000000000000000005e0877a8f6692ed470013e651c4357d0c4941e6c` <br/> |
There was a problem hiding this comment.
The value in the before in the before is incorrect:
Suggested change
| **Before**: `0x0000000000000000000000005e0877a8f6692ed470013e651c4357d0c4941e6c` <br/> | |
| **Before**: `0x000000000000000000000000924d3d3b3b16e74bab577e50d23b2a38990dd52c` <br/> |
Ethnical
reviewed
Jan 7, 2025
| Before this task has been executed, you will see that the returned address is `0x0000000000000000000000005e0877a8f6692ed470013e651c4357d0c4941e6c`, matching the "Before" value of this slot, demonstrating this slot is storing the address of the CANNON implementation. | ||
|
|
||
| - **Key**: `0x4d5a9bd2e41301728d41c8e705190becb4e74abe869f75bdb405b63716a35f9e` <br/> | ||
| **Before**: `0x0000000000000000000000004ed046e66c96600dae1a4ec39267bb0ce476e8cc` <br/> |
There was a problem hiding this comment.
The value in the before is incorrect:
Suggested change
| **Before**: `0x0000000000000000000000004ed046e66c96600dae1a4ec39267bb0ce476e8cc` <br/> | |
| **Before**: `0x000000000000000000000000879e899523ba9a4ab212a2d70cf1af73b906cbe5` <br/> |
Ethnical
reviewed
Jan 7, 2025
| **Before**: `0x0000000000000000000000005e0877a8f6692ed470013e651c4357d0c4941e6c` <br/> | ||
| **After**: `0x000000000000000000000000833a817ef459f4ecdb83fc5a4bf04d09a4e83f3f` <br/> | ||
| **Meaning**: Updates the CANNON game type implementation. You can verify which implementation is set using `cast call 0x05F9613aDB30026FFd634f38e5C4dFd30a197Fa1 "gameImpls(uint32)(address)" 0`, where `0` is the [`CANNON` game type](https://github.com/ethereum-optimism/optimism/blob/op-contracts/v1.4.0/packages/contracts-bedrock/src/dispute/lib/Types.sol#L28). | ||
| Before this task has been executed, you will see that the returned address is `0x0000000000000000000000005e0877a8f6692ed470013e651c4357d0c4941e6c`, matching the "Before" value of this slot, demonstrating this slot is storing the address of the CANNON implementation. |
There was a problem hiding this comment.
Here, also we need to update the value accordingly with the correct game address in the before (matching the screen).
Ethnical
reviewed
Jan 7, 2025
| **Before**: `0x0000000000000000000000004ed046e66c96600dae1a4ec39267bb0ce476e8cc` <br/> | ||
| **After**: `0x000000000000000000000000bbd576128f71186a0f9ae2f2aab4afb4af2dae17` <br/> | ||
| **Meaning**: Updates the PERMISSIONED_CANNON game type implementation. You can verify which implementation is set using `cast call 0x05F9613aDB30026FFd634f38e5C4dFd30a197Fa1 "gameImpls(uint32)(address)" 1`, where `1` is the [`PERMISSIONED_CANNON` game type](https://github.com/ethereum-optimism/optimism/blob/op-contracts/v1.4.0/packages/contracts-bedrock/src/dispute/lib/Types.sol#L31). | ||
| Before this task has been executed, you will see that the returned address is `0x0000000000000000000000004ed046e66c96600dae1a4ec39267bb0ce476e8cc`, matching the "Before" value of this slot, demonstrating this slot is storing the address of the PERMISSIONED_CANNON implementation. |
There was a problem hiding this comment.
Here, also we need to update the value accordingly with the correct game address in the before (matching the screen).
Ethnical
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds task to fix the Sepolia FP upgrade, since the old one (#374) referenced a wrongly newly deployed
DelayedWETHimplementation.Also adds a framework for creating reusable verification scripts.The framework was split into its own PR with #429Additional context
This task may actually be obsolete because of #410update: it's necessary because #410 reused the wrongDelayedWETHs.Based on #442 which adds additional checks to DG upgrades.
Metadata
Towards ethereum-optimism/optimism#13033