Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote-to-standard has unexpected behaviour on non-standard-candidate chains #347

Open
geoknee opened this issue Jun 28, 2024 · 1 comment

Comments

@geoknee
Copy link
Collaborator

geoknee commented Jun 28, 2024

  • It should be a no-op on standard chains.

  • It should only modify the intended config file fields, it should not modify the hardfork times for instance.

@geoknee
Copy link
Collaborator Author

geoknee commented Jul 9, 2024

I think this command would benefit from some e2e tests. I noticed today that it also adds hardfork times to the config file, which I don't think we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant