-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use toml instead of yaml for chain config files #386
Conversation
b1c519c
to
c95da5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me so far, left a few comments.
The We should migrate superchain-registry/scripts/codegen.js Lines 7 to 11 in 5d2f856
to be performed by the existing Go codegen tool: superchain-registry/superchain/internal/codegen/main.go Lines 33 to 34 in 5d2f856
I think we have all of the utility code we need to do that. Finally, we would trim the |
…rchain-registry into ss/toml-over-yaml
* fix(bindings): use toml configs * fix(bindings): no need to read extra dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust code GTG. go LGTM.
Description
Instead of using a combination of toml, yaml, and json config files, this PR combines the old config yaml, addresses json, and genesis-system-config json into a single toml file. This should make it easier to maintain the
superchain
package bindings going forward. There are already rust and go bindings for that package, but it will also be easier to add other languages in the future.There are no breaking changes for downstream packages (i.e. op-geth and op-node) introduced by this PR. Instead, the
superchain
packageinit()
function has just been updated so that it can parse the single toml config file and then populate the same data structures that were exported before.Additional Context
Fixes #285