Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superchain: export single mapping instead of three separate ones #391

Open
bitwiseguy opened this issue Jul 16, 2024 · 0 comments
Open

superchain: export single mapping instead of three separate ones #391

bitwiseguy opened this issue Jul 16, 2024 · 0 comments

Comments

@bitwiseguy
Copy link
Collaborator

Context: #386 (comment)

This would introduce a breaking change for op-node, op-geth and any other downstream software that imports the superchain package (e.g. op-reth), but it would be a nice cleanup. Right now the superchain package populates three mappings:

var OPChains = map[uint64]*ChainConfig{}
var Addresses = map[uint64]*AddressList{}
var GenesisSystemConfigs = map[uint64]*SystemConfig{}

After moving to toml config files, all of the data is contained in the OPChains mapping so we could remove the Addresses and GenesisSystemConfig ones to reduce duplicated data. But the downstream software would need to be updated to parse the updated ChainConfig struct for that data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant