Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Feature Branch ] Genesis allocs validation #489

Merged
merged 44 commits into from
Sep 3, 2024
Merged

[ Feature Branch ] Genesis allocs validation #489

merged 44 commits into from
Sep 3, 2024

Conversation

geoknee
Copy link
Collaborator

@geoknee geoknee commented Aug 19, 2024 •
edited
Loading

  • Modifies add-chain flow to store sufficient metadata to validate the allocs in a chain's genesis file
  • Adds a genesis package under the validation module, which contains a test to perform full genesis allocs validation
    • It does this by cloning the monorepo, checking out the declared commit, building and generating the l2 genesis using the deploy-config as input. The test can handle multiple different node versions, go versions, and genesis command invocations
    • This full check is only triggered if the validation metadata for a given chain is modified
    • The check is seperate from the other validation checks, so has its own triggers and conditions
    • For each chain modified in this way, we generate a dynamic CI configuration to run the validations concurrently, and then report a single "fan-in" result requiring all to pass
  • Adds a "lite" check for each chain, run as a part of the regular validation suite, which requires the chain has a "genesis creation commit" stored for it.
  • Adds validation metadata for several chains already in the registry, as well as some not yet in the registry (this allows us to save that metadata so we can use it later).

Closes #486
Closes #372
Towards #478

geoknee
geoknee commented Aug 19, 2024
View reviewed changes
superchain/superchain.go Outdated Show resolved Hide resolved
@geoknee geoknee changed the title "approach 2" "approach 2" for genesis allocs validation Aug 19, 2024
geoknee
geoknee commented Aug 19, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@geoknee geoknee mentioned this pull request Aug 20, 2024
Closed
9 tasks
@geoknee geoknee added the F-do-not-merge Flag: Do Not Merge label Aug 20, 2024
@geoknee geoknee changed the title "approach 2" for genesis allocs validation [ Feature Branch ] Genesis allocs validation Aug 20, 2024
This was referenced Aug 23, 2024
Merged
Merged
Closed
Merged
@geoknee geoknee added the A-validation Area: validation label Aug 29, 2024
@geoknee
Copy link
Collaborator Author

geoknee commented Aug 29, 2024 •
edited
Loading

Action plan:

  • Merge the stack of PRs into this one.
  • Rebase or update this PR
  • Confirm all known chains still validate correctly
  • Separate out any new chains being added on this PR, to get a streamlined version which only commits
    i. the add-chain code
    ii. the validation code itselg
    iii. the validation input files (meta.toml and deploy-config.toml)
  • We save the new chain information onto another feature branch which we can continue to use to validate all of the chains we care about until they have been merged to main in the usual way

This was referenced Aug 30, 2024
Merged
Merged
bitwiseguy
bitwiseguy reviewed Aug 30, 2024
View reviewed changes
add-chain/main.go Outdated Show resolved Hide resolved
geoknee and others added 15 commits September 2, 2024 12:24
@geoknee
harmonize op-geth version
b050367
@geoknee
improve naming of ci steps
69c48e0
@geoknee
dedupe perChainTestName
c178744
@geoknee
remove temporary directory after tests run
595c23c
@geoknee
tidy up test script
6826794
@geoknee
rename test
fc42646
@geoknee
rename commands
62d5792
@geoknee
add testGenesisAllocsMetadata
e1f4ccc
@geoknee @vdamle
use dynamic config building in CI (#534)
935c343 
* use dynamic config building in CI

This works by having a small workflow run, compute the list of chain ids to run genesis validation checks on, and then modify a subsequent config file which circleci then runs.

* add comment

* fan in

* fix

* fix script

* Update .circleci/continue_config.yml

Co-authored-by: Vinod Damle <[email protected]>

---------

Co-authored-by: Vinod Damle <[email protected]>
@geoknee
remove temporarily added chains (#535)
2899b13 
* git restore --source=main -- superchain

* just codegen

* just lint-all

* lint

* typo
@geoknee
enhance comment
d28945c
@geoknee
swap op-node1 and op-node2
8c74027 
to retain chronological ordering
@geoknee
add explainer about parallelism
093c826
@geoknee
modify message in genesis-allocs-all-ok
e74a1ea
@geoknee
simplify patch file
9b7f6d8
@geoknee geoknee mentioned this pull request Sep 2, 2024
Merged
1 task
bitwiseguy
bitwiseguy approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@bitwiseguy bitwiseguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@geoknee geoknee enabled auto-merge (squash) September 3, 2024 15:57
@geoknee geoknee merged commit 9c9ba65 into main Sep 3, 2024
22 checks passed
@geoknee geoknee deleted the gk/gen-val-met branch September 3, 2024 15:57
@geoknee geoknee mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdamle vdamle vdamle left review comments

@bitwiseguy bitwiseguy bitwiseguy approved these changes

Assignees
No one assigned
Labels
A-validation Area: validation F-do-not-merge Flag: Do Not Merge
Projects
None yet
Milestone
No milestone
3 participants
@geoknee @vdamle @bitwiseguy