wip: predpeloy bytecode validation (approach 1) #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Aug 13, 2024
validation/foundry-config.patch
Outdated
Comment on lines
9
to
10
| - "@cwia/=node_modules/clones-with-immutable-args/src", | ||
| + "@cwia/=node_modules/clones-with-immutable-args", |
There was a problem hiding this comment.
This patch file is needed to compile contracts in the monorepo at the specified commit.
geoknee
commented
Aug 13, 2024
geoknee
commented
Aug 13, 2024
validation/genesis-predeploy_test.go
Outdated
|
|
||
| chainId := uint64(34443) // Mode mainnet | ||
|
|
||
| monorepoCommit := "d80c145e0acf23a49c6a6588524f57e32e33b91c" |
There was a problem hiding this comment.
This commit was provided by the security team as the commit used by conduit to generate the genesis for Mode.
geoknee
commented
Aug 13, 2024
needs a fix
* add source command back to shell script for local testing * refactor predeploy test file with more functions * justfile: fix regex to only run single CHAIN_ID, not supersets * validation: optimize predeploy amount of code run per chain * refactor predeploy test to remove some lines of code --------- Co-authored-by: George Knee <[email protected]>
|
In favour of #489 , we won't delete the branch yet though. |
geoknee
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next steps:
Towards #372