-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validation: verify eth-da via latest batcher tx #421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Jul 26, 2024
bitwiseguy
force-pushed
the
ss/datype-validation
branch
from
July 26, 2024 17:59
54465e8
to
88686f7
Compare
bitwiseguy
requested review from
ajsutton,
clabby and
refcell
and removed request for
ajsutton and
clabby
July 26, 2024 18:01
sebastianst
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this also needs a rust reviewer now.
bitwiseguy
commented
Jul 29, 2024
sebastianst
approved these changes
Jul 30, 2024
refcell
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the updated
op-service/eth
packagesCheckRecentTxs
to perform a binary search to find the most recent batcher tx. If the tx exists within the lastChainConfig.SequencerWindowSize
blocks on mainnet, then the chain passes the test foreth-da
. Only checkingeth-da
for now.Additional context
Follow-up work will be to detect and verify
alt-da
, as described in #406Metadata
Closes #400