-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lisk Mainnet to the Superchain Registry #502
base: main
Are you sure you want to change the base?
Conversation
With all recent updates, changes inside Additional Information are not needed anymore to successfully execute |
Excellent! |
"baseFeeVaultRecipient": "0xdA6e5640aFB2ED212Ba3a6fd83076e2ad3daD185", | ||
"l1FeeVaultRecipient": "0xdA6e5640aFB2ED212Ba3a6fd83076e2ad3daD185", | ||
"sequencerFeeVaultRecipient": "0xdA6e5640aFB2ED212Ba3a6fd83076e2ad3daD185", | ||
"baseFeeVaultMinimumWithdrawalAmount": "0x8ac7230489e80000", | ||
"l1FeeVaultMinimumWithdrawalAmount": "0x8ac7230489e80000", | ||
"sequencerFeeVaultMinimumWithdrawalAmount": "0x8ac7230489e80000", | ||
"baseFeeVaultWithdrawalNetwork": 0, | ||
"l1FeeVaultWithdrawalNetwork": 0, | ||
"sequencerFeeVaultWithdrawalNetwork": 0, | ||
"proxyAdminOwner": "0xdA6e5640aFB2ED212Ba3a6fd83076e2ad3daD185", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please double check these changes? The automatic genesis validation check validate-genesis-allocs
uses this data, and the existing values were enough to make it pass, the new values cause it to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed the changes with our RaaS provider, which were made when ownership of the chain was transferred from the deployer EOA to a multisig. The values were also adjusted (decreased) for fee withdrawals. As a result, the new values are correct.
This was not the case for Lisk Sepolia so genesis validation check passes inside its PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All those changes were made around 22nd July 2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. For the genesis validation routine, we need the deploy-config as it was at the time the original genesis was generated, we don't actually care about changes that happened after that in this context. So best to revert these changes (the deploy-config.json won't be used for anything else).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the changes inside deploy-config.json
file.
Adding a New Chain
This PR adds Lisk Mainnet to the registry.
Checklist
just validate 1135
locally to ensure all local validation checks pass.just codegen
to ensure that the chainlist and other generated files are up-to-date and include my chain.Additional Information
To enable the
just add-chain
andjust codegen
commands to function correctly, I had to make a few changes:LiskMainnetChainID = 1135
case
statement:EIP1559DenominatorCanyon
is hardcoded to250
, which does not align with Lisk Mainnet (and Sepolia).Additionally, the
just validate
command also fails for some of the unit tests.