fix(rust-bindings): Use fixed-bytes B256 for overhead and scalar in SystemConfig #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianBland
force-pushed
the
fix-system-config-types
branch
2 times, most recently
from
758346a
to
8d30e89
Compare
BrianBland
force-pushed
the
fix-system-config-types
branch
from
8d30e89
to
e9ddfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type of the SystemConfig fields
overheadandscalarfromU256toB256, as these are assumed to be fixed-length fields in the reference go implementation.By using fixed-length types, it should be possible to serialize a
SystemConfigfrom the rust bindings and then deserialize these into code in the golang monorepo.Checklist
just validate <chain-id>locally to ensure all local validation checks pass.just codegento ensure that the chainlist and other generated files are up-to-date and include my chain.