Add ERC: ERC-721 Guarantee Extension #349

iunknow588 · 2024-03-28T06:42:22Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

Reference implementation will be provided later

eip-review-bot · 2024-03-28T06:42:52Z

✅ All reviewers have approved.

github-actions · 2024-03-28T06:49:36Z

The commit 178c74f (as a parent of 69e31bf) contains errors.
Please inspect the Run Summary for details.

ERCS/erc-7652.md

SamWilsn · 2024-06-03T14:42:52Z

ERCS/erc-7652.md

+---
+eip: 7652
+title: ERC-721 Guarantee Extension
+description: ERC-721 Guarantor role interface extension


Your description doesn't really add any information not in your title. Try to expand on the ideas you've introduced in the title. For example, you could explain what an ERC-721 guarantee actually is.

Thank you for your suggestion, the modification is as follows.
description: An extension interface that can guarantee NFT holders the ability to exchange their NFTs for circulating tokens at any time

SamWilsn · 2024-06-03T14:44:09Z

ERCS/erc-7652.md

+
+## Abstract
+
+This specification defines functions outlining a guarantor role for instance of [EIP-721](./eip-721.md). The guarantee interface implements the user-set valuation and guarantee share for a given NFT (token ID), as well as the guarantee rights enjoyed and obligations assumed during subsequent transactions. An implementation enables the user to read or set the current guarantee value for a given NFT (token ID), and also realizes the distribution of guarantee interest and the performance of guarantee obligations. It sends the standardized events when the status changes. This proposal relies on and extends the existing [EIP-721](./eip-721.md).


This is a decent abstract, but could use a bit of text explaining what a "guarantor role" is.

Thank you for your proposal, the new abstract has added a description of the responsibilities and rights of the guarantor:
Any participant can act as a guarantor to provide a subjective value assessment for an NFT. The guarantor's assessed value represents both the price the guarantor is willing to buy the NFT for and the weight value for sharing the guarantor's commission.

SamWilsn · 2024-06-03T14:44:38Z

ERCS/erc-7652.md

+
+## Motivation
+
+NFT (token ID) commonly face the issue of insufficient market liquidity: the main reason being the lack of transparency in NFT pricing, making it difficult for users to cash out after trading and purchasing NFT (token ID).


How is "token ID" related to NFT here?

Thank you for your attention. There is just a slight difference in detail, which is a specific NFT within the set of NFTs.

SamWilsn · 2024-06-03T14:45:32Z

ERCS/erc-7652.md

+
+With the introduction of the guarantor role, different guarantor groups can offer various price guarantees for NFT (token ID), establishing a multi-faceted price evaluation system for NFT (token ID).
+
+After purchasing an NFT (token ID), users can return it to the guarantor at any time at the highest guaranteed price to protect their interests.


I don't think you need to follow NFT with "token ID" every time you use the initialism.

Thank you for your suggestion, the new version has removed these redundant expressions.

SamWilsn · 2024-06-03T15:46:04Z

ERCS/erc-7652.md

+
+The keywords “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.
+
+Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.


Suggested change

Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.

Every contract compliant with this proposal MUST implement the `IERC721Guarantee` guarantee interface.

Thank you for your suggestion, the new version has made the relevant revisions to the wording.

SamWilsn · 2024-06-03T15:46:37Z

ERCS/erc-7652.md

+
+Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.
+
+The **guarantee extension**  is OPTIONAL for EIP-721 contracts.


Suggested change

The **guarantee extension** is OPTIONAL for EIP-721 contracts.

You can just omit this because it's always implied. You can't place requirements on implementations of other proposals.

Thank you for your suggestion, the new version has made the relevant revisions to the wording.

SamWilsn · 2024-06-03T15:47:40Z

ERCS/erc-7652.md

+Key factors influencing the standard:
+
+- Pay attention to ensuring fairness between and within groups when allocating commissions
+- Keeping the number of guarantee groups (DAOs)in the interfaces to prevent contract bloat
+- The guarantee group is a DAO contract, which MUST implement the `ERC721TokenReceiver` interface
+- Simplicity
+- Gas Efficiency


You should go in-depth on specific choices you made, not give general thoughts on your design.

Thank you for your suggestion,
These descriptions are issues that should be focuses on in the coding implementation.
The reference implementation will also pay attention to these issues.

SamWilsn · 2024-06-03T15:48:07Z

ERCS/erc-7652.md

+## Reference Implementation
+
+The reference implementation will be provided later.
+


Suggested change

## Reference Implementation

The reference implementation will be provided later.

Just remove this section until you have the reference implementation ready.

Thank you for your suggestion, the new version has made the relevant revisions to the wording.

SamWilsn · 2024-06-03T15:48:31Z

ERCS/erc-7652.md

+
+## Security Considerations
+
+Needs discussion.


Suggested change

Needs discussion.

Needs discussion. 

If you use HTML-style comments, the linter will make sure you come back to them before going into the next status.

Thank you for your suggestion, the new version has corrected this mistake. Very appreciate it.

edit's suggest

检查版本错误的原因

description: 开头多余的空格是错误的

检查错误原因……

错误定位处理

错误故障定位处理

故障定位

故障定位……

故障定位

SamWilsn · 2024-09-10T21:40:17Z

Did you publish the new version somewhere? I can't see it in the "Files Changed" tab, so I can't review it 😅

github-actions · 2025-03-13T00:02:12Z

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

eip-review-bot

All Reviewers Have Approved; Performing Automatic Merge...

iunknow588 added 3 commits March 28, 2024 14:35

ERC-721 Guarantee Extension

2a75d6d

Reference implementation will be provided later

Update erc-7652.md

8a509e5

Update erc-7652.md

178c74f

iunknow588 requested a review from eip-review-bot as a code owner March 28, 2024 06:42

github-actions bot added c-new s-draft t-erc labels Mar 28, 2024

eip-review-bot added e-consensus e-review labels Mar 28, 2024

github-actions bot added the w-ci label Mar 28, 2024

Update erc-7652.md

5d79f99

github-actions bot removed the w-ci label Mar 28, 2024

xinbenlv reviewed Mar 29, 2024

View reviewed changes

ERCS/erc-7652.md Outdated Show resolved Hide resolved

xinbenlv reviewed Mar 29, 2024

View reviewed changes

ERCS/erc-7652.md Outdated Show resolved Hide resolved

xinbenlv reviewed Mar 29, 2024

View reviewed changes

ERCS/erc-7652.md Show resolved Hide resolved

iunknow588 and others added 4 commits March 30, 2024 10:10

Merge branch 'ethereum:master' into master

f7605b7

eip => erc

eb782fa

Merge branch 'master' into master

6ec1b62

Merge branch 'master' into master

8e7d6f3

SamWilsn reviewed Jun 3, 2024

View reviewed changes

iunknow588 added 8 commits June 26, 2024 10:18

Merge branch 'ethereum:master' into master

76f7b28

Update erc-7652.md

d8e7a91

edit's suggest

Merge branch 'ethereum:master' into master

53ed825

Merge branch 'ethereum:master' into master

e5faf45

Merge branch 'ethereum:master' into master

ecb720f

Update erc-7652.md

e19e5d9

Update erc-7652.md

28d18da

检查版本错误的原因

Update erc-7652.md

d8a78fa

description: 开头多余的空格是错误的

iunknow588 and others added 10 commits July 28, 2024 22:17

Update erc-7652.md

829818c

检查错误原因……

Update erc-7652.md

be1ab01

错误定位处理

Update erc-7652.md

6c49058

错误故障定位处理

Update erc-7652.md

7e492f3

故障定位

Update erc-7652.md

8843c9c

故障定位……

Update erc-7652.md

73c8469

故障定位

Update erc-7652.md

721222b

故障定位

Update erc-7652.md

1404d6d

故障定位

Update erc-7652.md

3026394

故障定位

Update erc-7652.md

14c53b0

github-actions bot added the w-stale label Mar 13, 2025

xinbenlv approved these changes Apr 7, 2025

View reviewed changes

eip-review-bot enabled auto-merge (squash) April 7, 2025 00:07

eip-review-bot approved these changes Apr 7, 2025

View reviewed changes

eip-review-bot merged commit a3f1588 into ethereum:master Apr 7, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ERC: ERC-721 Guarantee Extension #349

Add ERC: ERC-721 Guarantee Extension #349

iunknow588 commented Mar 28, 2024

eip-review-bot commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn Jun 3, 2024

iunknow588 Jun 26, 2024

SamWilsn commented Sep 10, 2024

github-actions bot commented Mar 13, 2025

eip-review-bot left a comment


		## Abstract

		This specification defines functions outlining a guarantor role for instance of [EIP-721](./eip-721.md). The guarantee interface implements the user-set valuation and guarantee share for a given NFT (token ID), as well as the guarantee rights enjoyed and obligations assumed during subsequent transactions. An implementation enables the user to read or set the current guarantee value for a given NFT (token ID), and also realizes the distribution of guarantee interest and the performance of guarantee obligations. It sends the standardized events when the status changes. This proposal relies on and extends the existing [EIP-721](./eip-721.md).


		## Motivation

		NFT (token ID) commonly face the issue of insufficient market liquidity: the main reason being the lack of transparency in NFT pricing, making it difficult for users to cash out after trading and purchasing NFT (token ID).


		With the introduction of the guarantor role, different guarantor groups can offer various price guarantees for NFT (token ID), establishing a multi-faceted price evaluation system for NFT (token ID).

		After purchasing an NFT (token ID), users can return it to the guarantor at any time at the highest guaranteed price to protect their interests.


		The keywords “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

		Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.

	Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.
	Every contract compliant with this proposal MUST implement the `IERC721Guarantee` guarantee interface.


		Every contract compliant to the `ERC721Guarantee` MUST implement the `IERC721Guarantee` guarantee interface.

		The guarantee extension is OPTIONAL for EIP-721 contracts.

		## Reference Implementation

		The reference implementation will be provided later.

Add ERC: ERC-721 Guarantee Extension #349

Add ERC: ERC-721 Guarantee Extension #349

Conversation

iunknow588 commented Mar 28, 2024

eip-review-bot commented Mar 28, 2024 • edited Loading

github-actions bot commented Mar 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamWilsn commented Sep 10, 2024

github-actions bot commented Mar 13, 2025

eip-review-bot left a comment

Choose a reason for hiding this comment

eip-review-bot commented Mar 28, 2024 •

edited

Loading