Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: Guidelines for Finalizing ERCs #857

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add ERC: Guidelines for Finalizing ERCs #857

wants to merge 10 commits into from

Conversation

bumblefudge
Copy link

For more context, see:

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 19, 2025 •
edited
Loading

File ERCS/erc-7865.md

Requires 1 more reviewers from @lightclient, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title New ERC: Informational ERC with best practices for ERC adoption Add ERC: Guidelines for Finalizing ERCs Jan 19, 2025
@github-actions github-actions bot added the w-ci label Jan 19, 2025
bomanaps
bomanaps reviewed Jan 27, 2025
View reviewed changes
Copy link

@bomanaps bomanaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the document and left comments highlighting a few areas that need attention to ensure compliance with the EIP guidelines. Please review them and make the necessary updates. Thank you.

ERCS/erc-7865.md

## Rationale

This informational document was inspired by the exemplary coordination process behind ERC-4361 and EIP-6963, EIPIP discussions with EIP editors, and discussions in the Chain Agnostic Standards Alliance.
Copy link

@bomanaps bomanaps Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first mention of ERC-4361 and EIP-6963 must be hyperlinked to their respective EIP/ERC pages, as per the EIP guidelines. Please refer to the Markdown Rel Links for more information.

@bumblefudge
Copy link
Author

whoops sorry for the misnaming in the commit names, bomanaps! 🤦

bomanaps
bomanaps reviewed Jan 29, 2025
View reviewed changes
@github-actions github-actions bot added the w-ci label Jan 29, 2025
@github-actions GitHub Actions
Copy link

The commit 690e20e (as a parent of b23eecc) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomanaps bomanaps bomanaps left review comments

@eip-review-bot eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot will be requested when the pull request is marked ready for review eip-review-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-informational w-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bumblefudge @eip-review-bot @bomanaps @SamWilsn