Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Splitting and Merging of NFTs #930

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

nitin312
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 27, 2025

File ERCS/erc-7891.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title erc 7891 update1 Add ERC: Splitting and Merging of NFTs Feb 27, 2025
@github-actions github-actions bot added the w-ci label Feb 27, 2025
Copy link

@bomanaps bomanaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you also review the red flags raised by the bots and properly format the links?

@bomanaps
Copy link

bomanaps commented Feb 27, 2025

You have two PRs open for the same proposal? PR 923 , PR 920

Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited based on provided error details

@github-actions github-actions bot removed the w-ci label Mar 26, 2025
@nitin312
Copy link
Author

@eip-review-bot, could you please review this PR #930? It's passed all checks and is ready for merging. If there's anything I need to address, please let me know. Thanks!

@nitin312
Copy link
Author

@eip-review-bot @g11tech @SamWilsn @xinbenlv
Would you kindly take a review of PR #930 for proposal ERC-7891? The proposal has passed all required checks and is ready for merging.
Let me know if there are any final changes needed. Thanks!

Restore erc-7891 contents
@github-actions github-actions bot added w-ci and removed w-ci labels Apr 1, 2025
nitin312 added 10 commits April 1, 2025 15:58
Edited based on comment
Edited based on comment
Edited based on comment
Edited based on comment
edited first line
First line --- verified
Copy link

github-actions bot commented Apr 1, 2025

The commit 365f4e1 (as a parent of 24fac02) contains errors.
Please inspect the Run Summary for details.

Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line ---edit

@github-actions github-actions bot removed the w-ci label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants