Specify blobs by root condition if there's equivocating blobs #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
djrtwo
reviewed
Oct 27, 2023
| @@ -292,6 +292,10 @@ Clients MUST support requesting sidecars since `minimum_request_epoch`, where `m | |||
| Clients MUST respond with at least one sidecar, if they have it. | |||
| Clients MAY limit the number of blocks and sidecars in the response. | |||
|
|
|||
| In the event of equivocating blobs, clients MUST serve only blobs with matching KZG commitments if they have seen the block. | |||
There was a problem hiding this comment.
I'm not sure this is necessary if #3531 is merged. Because you now have an explicit tie between the blobs and the block header at the point of gossip acceptable
|
How is this different from #3532 ? |
This is RPC behavior. 3532 is Gossip behavior. We most likely won't need both once blob sidecar has inclusion proof. These can be closed once inclusion proof is merged |
|
closing in favor of #3531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t to @realbigsean for the comment
This PR introduces an explicit condition for handling blob responses by root in cases of blob equivocation. Ensures clients adhere to specified behavior for serving blobs with matching KZG commitments or the first valid blobs they encounter, depending on whether the block has been seen.
Notes: