Separate type for aggregated committee attestation #4005
+21
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppopth
reviewed
Nov 27, 2024
ppopth
reviewed
Nov 27, 2024
ppopth
reviewed
Nov 27, 2024
|
Referencing #3900 (comment) and #3787 which have kind of similar ideas. |
Co-authored-by: Pop Chunhapanya <[email protected]>
ensi321
force-pushed
the
aggregate-attestation
branch
from
10caa33 to
44989b0
Compare
arnetheduck
approved these changes
Dec 20, 2024
|
Please, fix that one of the checks is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing separate container for aggregated attestation in a committee. The new container replaces the unnecessary committee bits with committee index. It also has 63x shorter max length than
Attestationonaggregation_bitswhich yields max size going from 16.23kb to 0.48kb. This ensures aggregates with 63 committees worth of zeros in aggregation bits with not be deserialized.The current
Attestationrepresents aggregated attestation both on-chain and in a committee. Having a dedicated container for committee attestation improves readability and removes the need to maintain a one-bit-set committee bit list.