Roadmap tracks page #15351
Roadmap tracks page #15351
Conversation
corwintines
requested review from
wackerow,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
@corwintines great job! 🔥
I think we could make a good refactor around nodes.
Most, if not all, of the nodes share the same behavior, with the main differences being their styles and shapes. So, we could create a single CustomNode component and implement the different styles using the same approach and conventions we follow for other UI components from the DS.
We could have:
- variants: “rectangle”, “circle”
- status: "success", "primary"
- size: “md”, “lg”
and:
- targets: a list of
Positions - sources: a list of
Positions
With the use of cva we could implement this pretty easily as we do with the Buttons, or Tags.
// this could replace the "Warmup fork" node
<Node variant="success" label="Warmup fork" button="shipped" targets=["left"] sources=["right"] />
// this one the Merge one that has a bigger font size and padding
<Node variant="success" size="lg" label="Merge!" button="shipped" ... />There was a problem hiding this comment.
We already have this image in https://github.com/ethereum/ethereum-org-website/blob/dev/public/images/people-learning.png
Is it possible to reuse it?
| <div className="rounded-full bg-warning px-2 py-1"> | ||
| <p className="text-xs text-black">SCHEDULED</p> | ||
| </div> |
There was a problem hiding this comment.
I'd like us to be able to build on top of existing DS components.
IMO we should use the Tag component in this case https://dev--63b7ea99632763723c7f4d6b.chromatic.com/?path=/story/molecules-display-content-tags--style-variants-basic
|
|
||
| import { useActiveHash } from "@/hooks/useActiveHash" | ||
|
|
||
| type NodeData = { |
There was a problem hiding this comment.
we could export this type and use it in each node
| @@ -0,0 +1,380 @@ | |||
| import { MarkerType } from "@xyflow/react" | |||
| import { Edge, Node } from "@xyflow/react" | |||
| const mergeNodes: Node[] = [ | |||
There was a problem hiding this comment.
Noted that we can import our custom NodeData type and extend it here Node<NodeData>[] to have type safety in the data object
|
(Placing in draft while the TODO placeholder copy remains) |
refactor: use tailwind native bg gradient classes
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
[Draft] Roadmap Copy
Preview link
https://deploy-preview-15351--ethereumorg.netlify.app/en/roadmap/tracks/