Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution-apis: Add EIP-7594 (PeerDAS) related changes #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
execution-apis: Add EIP-7594 (PeerDAS) related changes #630
Changes from 3 commits
bee872a
c4c3a56
9202e12
97c63a5
e1ab343
4bb5435
a67bb40
3f1ec95
10b47c6
2488897
9c14f08
eceae40
6116381
37dff61
0763aa8
125bb29
9355b35
a091e7c
cad4194
d74bb07
b9fb5e5
fe372bc
92f95ff
fe7c75f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When new versions of methods are introduced there is usually a statement on how to limit the scope of the previous versions. I think this doc should at least add modification to
engine_getPayloadV4
whileengine_getBlobsV2
is a bit more tricky in that regard, see https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#update-the-methods-of-previous-forks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great callout, added
update-the-methods-of-previous-forks
section forengine_getblobsv1
.As for getPayloadV4, previous section already specifies the validation should reject anything that's older than Prague, so it covers Osaka.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getPayloadV4
is introduced in Prague and it should also be mentioned that it must not be used for Osaka payloads as it is usually done