new(tests): Backfill tests for OOGing on constant gas #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
commented
Oct 20, 2025
| from ethereum_test_vm import Opcode, UndefinedOpcodes | ||
| from ethereum_test_vm import Opcodes as Op | ||
| from tests.unscheduled.eip7692_eof_v1.eip3540_eof_v1.opcodes import V1_EOF_ONLY_OPCODES | ||
| from tests.unscheduled.eip7692_eof_v1.gas_test import gas_test |
There was a problem hiding this comment.
my main point I'm not 100% sold on, but gas_test handles a ton of issues out-of-the-box for us. Once EOF tests are maybe removed it could be simplified and moved out of that EOF specific directory.
The bits that gas_tests handles:
- setting the exact amount of gas needed to oog
- warm and cold call
- sanity check, i.e. add one gas and no more oog
- (not) having to deal with intrinsic gas etc.
- in general - recognizing when the oog happened and when not - just by manipulating tx gas_limit is quite difficult
pdobacz
force-pushed
the
tests/constant-gas-oog
branch
from
613cffe to
a862e9c
Compare
pdobacz
commented
Oct 21, 2025
|
Thanks for this, i think this is necessary for upcoming gas-repricing refactor for us |
pdobacz
force-pushed
the
tests/constant-gas-oog
branch
from
a7fcd0e to
bcdb497
Compare
|
closing in favor of ethereum/execution-specs#1686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening here as draft to collect early feedback. I'll migrate the PR over to EELS once the Weld is complete.
This responds to a gap in coverage uncovered by
evmonecoverage report in lib/evmone/baseline_execution.cpp - it seems there was not test to cause opcodes to go out-of-gas on the very basic constant amount of gas.ethereum/testsethereum/legacytestsevmone's unittestshivefor a bunch of non-evmone clients.