Refactor includability check in forks

[richardgreg]

What was wrong?

Includability checks should be moved from process_transaction() to check_transaction()

Related to Issue #
Ref #799

How was it fixed?

• Moved the check code block from process_transaction() to check_transaction()
• Added the necessary function argument to check_transaction

Cute Animal Picture

[richardgreg]

Some process_transaction functions have ensure(validate_transaction(tx), InvalidBlock). Thought about moving them to process transaction too. What are your thoughts?

[richardgreg]

@petertdavies could you take a quick look and state if I'm on the right path?

[richardgreg]

@SamWilsn could you review this if you have the time? 🙂

[SamWilsn]

I'll do my best! Trying to get #925 merged before we start refactoring in earnest.

[gurukamath]

@richardgreg There might be a few more checks that we might have to move to check_transaction. I have raised a PR to make these changes in cancun (See PR). You could use a similar template to port the changes over to the other forks.

[richardgreg]

Awesome

[richardgreg]

Hi @gurukamath, I just dealt with some conflicts while performing a rebase. I will get around to adding the checks with your template as soon as possible, but if this PR is okay, I'll appreciate it if you merge it so I don't have to rebase again when I get back to the task 😅 🙏🏾

[richardgreg]

Does anyone know if these changes are still needed? I noticed it was approved two weeks ago but was never merged and now has a lot of conflicts

[SamWilsn]

@Bbjj88h is a spam bot as far as I can tell.

[SamWilsn]

Ah, sorry about the conflicts. We've removed the ensure function because it was hiding lines from code coverage in #932 & #944. I've assigned this to @petertdavies to walk you through and get this merged.