Add Database entries for every transfer failure #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
query-trace-failure-records
branch
from
acf1577 to
8e822b8
Compare
carver
force-pushed
the
query-trace-failure-records
branch
from
8e822b8 to
2862c65
Compare
The sea-orm tools will reorder based on date, which makes sense. Oddly, the date of the 'create census table' migration comes before other entities that it requires, like 'record'. So this change renames the migration to an impossible date, but one that keeps it in the same ordering that it was manually inserted at before the change. An impossible date was chosen as a flag that we don't really know when the migration occured.
Successful audits can contain failed transfers, because of retries. We would still like to record the failures for analysis. Migration success was manually confirmed with: DATABASE_URL=postgres://postgres:password@localhost:5432/glados sea-orm-cli migrate up Entity file was generated, using a command like this: sea-orm-cli generate entity -l -t audit_internal_failure --database-url postgres://postgres:password@localhost:5432/glados Includes a test that the helper function correctly records internal failures to DB, including the sender node ID and the type of failure. Note that the temp DB must be passed around the test, even though it isn't used directly. If it is dropped, then the connection to it will fail.
carver
force-pushed
the
query-trace-failure-records
branch
from
c23d573 to
0da52f0
Compare
carver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: rebase on #355Next major step toward #336 -- saving each transfer failure into the database.