-
Notifications
You must be signed in to change notification settings - Fork 20.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
params: updated bootnodes #3720
Conversation
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Just a few questions before we merge this is: On the ethstats page these bootnodes still have "TEST" in their names, perhaps we should swap those out? Also I saw that the old bootnodes have about 1K peers, whereas te new ones have 220K. Is this intentional? |
Good point, just removed the "TEST" from the ethstats flag on these new bootnodes. Originally I was uncertain how many peers these instances could handle while maintaining stable updates to ethstats. The BR, AU, and US-WEST were running with --maxpeers=256 during the test, I will now bring them up to 1024 and monitor how well they do. |
Ah ok. I'm not saying they have to be 1K, just noticed the number is different and thought it would be nice to ask about it. We can keep them lower-ish than the previous ones since we have more, but overall the new total should hover around the same as the old total. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will keep that in mind, thanks! I am actually unsure about how much capacity is needed in order to have a healthy network and provide a good experience for geth users. Another question is whether certain bootnodes should have more capacity at certain times. I have been focusing on the health of the individual bootnode instances, but now that the enodes are in params/bootnodes.go I will start thinking/asking more about the impact on the network and clients. |
Updated the MainnetBootnodes to improve peering resiliency and reduce costs. Modified the BR enode, added new enodes for US-WEST and AU.