Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: updated bootnodes #3720

Merged
merged 2 commits into from
Feb 28, 2017
Merged

params: updated bootnodes #3720

merged 2 commits into from
Feb 28, 2017

Conversation

jpitts
Copy link
Member

@jpitts jpitts commented Feb 27, 2017

Updated the MainnetBootnodes to improve peering resiliency and reduce costs. Modified the BR enode, added new enodes for US-WEST and AU.

@mention-bot
Copy link

@jpitts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karalabe and @fjl to be potential reviewers.

@GitCop
Copy link

GitCop commented Feb 27, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 7e1307d
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@karalabe
Copy link
Member

Just a few questions before we merge this is:

On the ethstats page these bootnodes still have "TEST" in their names, perhaps we should swap those out?

Also I saw that the old bootnodes have about 1K peers, whereas te new ones have 220K. Is this intentional?

@karalabe karalabe added this to the 1.6.0 milestone Feb 28, 2017
@jpitts
Copy link
Member Author

jpitts commented Feb 28, 2017

Good point, just removed the "TEST" from the ethstats flag on these new bootnodes.

Originally I was uncertain how many peers these instances could handle while maintaining stable updates to ethstats. The BR, AU, and US-WEST were running with --maxpeers=256 during the test, I will now bring them up to 1024 and monitor how well they do.

@karalabe
Copy link
Member

Ah ok. I'm not saying they have to be 1K, just noticed the number is different and thought it would be nice to ask about it. We can keep them lower-ish than the previous ones since we have more, but overall the new total should hover around the same as the old total.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit dbd88a1 into ethereum:master Feb 28, 2017
@jpitts
Copy link
Member Author

jpitts commented Feb 28, 2017

Will keep that in mind, thanks!

I am actually unsure about how much capacity is needed in order to have a healthy network and provide a good experience for geth users. Another question is whether certain bootnodes should have more capacity at certain times.

I have been focusing on the health of the individual bootnode instances, but now that the enodes are in params/bootnodes.go I will start thinking/asking more about the impact on the network and clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants