Verify: only check post root if provided #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
approved these changes
Jan 6, 2025
Collaborator
jsign
left a comment
jsign
left a comment
There was a problem hiding this comment.
LGTM.
I see that the tests fail, is this related to this bug still or another?
Member
Author
|
It's related to a bug we introduced when disabling the eoa optimization. I am about to push a fix. |
Signed-off-by: Guillaume Ballet <[email protected]>
gballet
force-pushed
the
optional-post-root-check-in-verify
branch
from
7674ab5 to
23faab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to verify the validity of the provided post-state root if it isn't provided.
This is necessary for gballet/go-ethereum#527 to work.