[REFACTOR] Circuit compiler actions #5238
Conversation
azarpoor
commented
Sep 30, 2024
azarpoor
commented
- improve coding structure of circuit compiler actions
- make it more readable
- remove some additional codes
- improve error handling
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
| } else { | ||
| console.log('Existing circuit compilation in progress') |
There was a problem hiding this comment.
hey thank you i correct this check
Aniket-Engg
force-pushed
the
refact/circuit-compiler-actions
branch
from
e0c0437 to
47cfe4d
Compare
Aniket-Engg
requested review from
ioedeveloper
and removed request for
dIvaD8
AmirH-A
force-pushed
the
refact/circuit-compiler-actions
branch
from
47cfe4d to
54fa591
Compare
|
hello hope your doing well , i have primary account which is this account with name AmirH-A i change the auther to this account , and if its needed to change commiter to this also i don't know i wanna mention this to you , thank you by the way |
|
@AmirH-A Can you rebase and fix the merge conflict? |
hey , yes of course |
| } | ||
|
|
||
| async function readFileAsUint8Array(plugin: CircomPluginClient, path: string): Promise<Uint8Array> { | ||
| const data = await plugin.call('fileManager', 'readFile', path) |
There was a problem hiding this comment.
Missing parameter to fileManager plugin call 'opt?' parameter. "{ encoding: null }". The type definition for fileManager is not updated for this additional option. You can use // @ts-ignore to ignore the error.
|
|
||
| async function readFileAsUint8Array(plugin: CircomPluginClient, path: string): Promise<Uint8Array> { | ||
| const data = await plugin.call('fileManager', 'readFile', path) | ||
| return new Uint8Array(data.split(',').map(byte => parseInt(byte, 10))) |
There was a problem hiding this comment.
Also, "data.split(',').map(byte => parseInt(byte, 10)" is not needed if you are reading bytes from the fileManager
|
thank you for review |
|
@azarpoor can you fix linting? |
hey , of course 👍 |
|
@Aniket-Engg |
|
circom related e2e are failing @azarpoor @ioedeveloper |
hey, ill check this issue 👍 |
|
hello hope you great how i can see the Tests ? for fixing this issue ? |
cc: @ioedeveloper |
|
@ioedeveloper @azarpoor e2e are still failing |
ioedeveloper
force-pushed
the
refact/circuit-compiler-actions
branch
from
8dbf9d2 to
eaf3108
Compare
|
@ioedeveloper what should we do with it? |
hello , i can resolve the merge conflict, ill do it |
