Skip to content

feat: improve error handling in TraceManager with TraceError class #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: improve error handling in TraceManager with TraceError class #5603

wants to merge 3 commits into from

Conversation

DeVikingMark
Copy link

Description:

  • Add TraceError class for better error handling and debugging
  • Include step index in error objects for improved context
  • Enhance error messages in buildCallPath, getCallStackAt and getStackAt methods
  • Preserve error context instead of string conversion

Benefits:

  • Better debugging experience with detailed error information
  • Type safety with specialized error class
  • Consistent error handling approach

@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6d35a43

@Aniket-Engg Aniket-Engg requested a review from yann300 January 6, 2025 12:17
@yann300 yann300 self-assigned this Jan 13, 2025
yann300
yann300 reviewed Jan 20, 2025
View reviewed changes
libs/remix-debug/src/trace/traceManager.ts
}
throw new TraceError('No stack data found for the given step index', stepIndex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be in a else statement.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yann300 made an update, and also provided a similar change to another place in code. Does it seem alright to you?

@Aniket-Engg Aniket-Engg requested a review from yann300 February 18, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 Awaiting requested review from yann300

At least 1 approving review is required to merge this pull request.

Assignees

@yann300 yann300

Labels
remix-debug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeVikingMark @yann300 @Aniket-Engg