Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging Paths normalizeContractPath.ts #5655

Closed
wants to merge 2 commits into from
Closed

Merging Paths normalizeContractPath.ts #5655

wants to merge 2 commits into from

Conversation

comfsrt
Copy link

@comfsrt comfsrt commented Jan 17, 2025

  • Changes Explanation:
    1. Removed the redundant condition if (i !== paths.length - 1) because the loop's stopping condition
  • already ensures it won't exceed the last element.
    1. Changed the loop start index to 1 to avoid duplicating the first path segment.
    1. Used a straightforward concatenation in every loop iteration to merge paths.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6db90da

@comfsrt comfsrt changed the title Update normalizeContractPath.ts Merging Paths normalizeContractPath.ts Jan 17, 2025
@Aniket-Engg
Copy link
Collaborator

build fails

@comfsrt comfsrt closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comfsrt @Aniket-Engg @GooseMatrix