Skip to content

Relayer signature forwarding #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franjoespejo wants to merge 11 commits into
base: main
Choose a base branch
from
+31 −4
Open

Relayer signature forwarding #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cdbbf43
Verify in BeaconBlockSigning
franjoespejo Jan 9, 2024
ecad874
removes value
franjoespejo Jan 9, 2024
8499d0f
more detailed schema, actual examples
franjoespejo Jan 11, 2024
2cf2101
make it optional
franjoespejo Jan 15, 2024
d7b3e29
format
franjoespejo Jan 15, 2024
7cca397
get verif properties
franjoespejo Jan 29, 2024
91f25cf
request relayer signature
franjoespejo Jan 29, 2024
6925ea5
adds relayer signature in the sign request
franjoespejo Feb 20, 2024
252e42a
rm relayer signature
franjoespejo Mar 26, 2024
271707a
relayer signature
franjoespejo Apr 2, 2024
86909a9
rm verifying w3s
franjoespejo Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions signing/paths/public_keys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,17 @@ get:
schema:
type: array
items:
type: string
example: '0x93247f2209abcacf57b75a51dafae777f9dd38bc7053d1af526f220a7489a6d3a2753e5f3e8b1cfe39b56f43611df74a'
oneOf:
- type: string
- type: object
properties:
pubkey:
type: string
relayer_signature:
type: boolean
example:
- pubkey: '0x93247f2209abcacf57b75a51dafae777f9dd38bc7053d1af526f220a7489a6d3a2753e5f3e8b1cfe39b56f43611df74a'
relayer_signature: true

@dapplion dapplion Apr 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, it should bump to a new version

'400':
description: 'Bad request format'
'500':
Expand Down
4 changes: 3 additions & 1 deletion signing/paths/sign.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ post:
BLOCK_V2 (DENEB):
value:
type: "BLOCK_V2"
proofs:
- relayer_signature: "0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505"

@dapplion dapplion Apr 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is additive but I am not sure if it deserves a new version. If we don't bump the version, the field has to be optional, and may not be present even if the web3signer requests it on the public_keys return

@rolfyone rolfyone Apr 4, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, optional, or new interface.

signingRoot: "0xaa2e0c465c1a45d7b6637fcce4ad6ceb71fc12064b548078d619a411f0de8adc"
fork_info:
fork:
Expand All @@ -65,7 +67,7 @@ post:
state_root: "0xfd18cf40cc907a739be483f1ca0ee23ad65cdd3df23205eabc6d660a75d1f54e"
body_root: "0xa759d8029a69d4fdd8b3996086e9722983977e4efc1f12f4098ea3d93e868a6b"
BLOCK_V2 (CAPELLA):
value:
value:
type: "BLOCK_V2"
signingRoot: "0xaa2e0c465c1a45d7b6637fcce4ad6ceb71fc12064b548078d619a411f0de8adc"
fork_info:
Expand Down
18 changes: 17 additions & 1 deletion signing/schemas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
components:
schemas:
Verifying:
type: "object"
properties:
proofs:
type: "array"
nullable: true
items:
type: "object"
properties:
relayer_signature:
type: "string"
nullable: true
description: Signature from Relayer
example: '0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505'
required:
- relayer_signature
Signing:
type: "object"
properties:
Expand Down Expand Up @@ -472,6 +488,7 @@ components:
type: string
BeaconBlockSigning:
allOf:
- $ref: '#/components/schemas/Verifying'
- $ref: '#/components/schemas/Signing'
- $ref: '#/components/schemas/BeaconBlockRequest'
- type: object
Expand All @@ -480,7 +497,6 @@ components:
type: "string"
description: Signing Request type
example: 'BLOCK_V2'

BeaconBlockRequest:
type: object
properties:
Expand Down