Replace signingRoot property with signing_root

[usmansaleem]

Replace signingRoot property with signing_root as all other properties are snake case.

Fixes #5

[james-prysm]

I think this change will need some reflection on the migration path. should we be introducing a new version or something?

[usmansaleem]

I think this change will need some reflection on the migration path. should we be introducing a new version or something?

The spec that is on the main branch can be treated as dev version. The spec that is available on the github release page (and is tagged) v1.0.0 is the one that web3signer currently implemented and other validator clients also support. The Deneb changes should be part of version release v1.1.0, for example. Similarly, signing_root change should be part of either 1.2.0 or 2.0.0.

[jframe]

If this is merged in though this would be part of the next release of the API v1.1.0 along with the Deneb changes and it would be a breaking change.

Would prefer that we had a release of the API with the Deneb without any breaking changes to the signing root and put this in the next release 1.2.0.

I think this change will need some reflection on the migration path. should we be introducing a new version or something?

The spec that is on the main branch can be treated as dev version. The spec that is available on the github release page (and is tagged) v1.0.0 is the one that web3signer currently implemented and other validator clients also support. The Deneb changes should be part of version release v1.1.0, for example. Similarly, signing_root change should be part of either 1.2.0 or 2.0.0.

[usmansaleem]

If this is merged in though this would be part of the next release of the API v1.1.0 along with the Deneb changes and it would be a breaking change.

Would prefer that we had a release of the API with the Deneb without any breaking changes to the signing root and put this in the next release 1.2.0.

Agreed, this PR should be merged after releasing 1.1.0 and/or, create/push tag with deneb related commit.