Executable for use with AFL #1703
Conversation
|
Error on windows is "block mining timeout" and can thus be ignored. |
|
|
||
| # search for test names and create ctest tests |
There was a problem hiding this comment.
What was the reason for this block and why isn't it needed anymore?
There was a problem hiding this comment.
This generated some auxiliary information so that ctest could be used as a test runner. The main advantage of ctest was that tests could be run in parallel. Since this is not possible anymore because of the IPC connection required, I did not see any reason to keep it.
| cd "$REPO_ROOT" | ||
| REPO_ROOT=$(pwd) # make it absolute | ||
| cd "$TMPDIR" | ||
| "$REPO_ROOT"/scripts/isolate_tests.py "$REPO_ROOT"/test/contracts/* "$REPO_ROOT"/test/libsolidity/*EndToEnd* |
There was a problem hiding this comment.
Shouldn't these errors caught by soltest? Or is the reason here to verify solfuzzer instead?
There was a problem hiding this comment.
These basically test solcjs, i.e. generating all the json structures for the output, we had some bugs there before.
There was a problem hiding this comment.
Yeah right, it is a rudimentary soljson test.
@holiman please just run
solfuzz < inputfilefor fuzz-testing, this will now catch much more errors.