-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable WAL mode on sqlite 1.39-1.9xing Trin performance #1662
Conversation
I want to test it one more time |
Hmm looks like I might have gotten something wrong, I am closing the issue for the time being |
So I improved the benchmark a little and I think the increase is less, but I found the bug Kim was telling me about and it looks pretty serious and I was able to reproduce it 2 times now, so I will debug that first before continuing with this PR |
Before So it seems like results vary a little but generally we are seeing a 1.4 to 1.9 times more performance, depending on uTP reliability which can hopefully be smoothed out with performance improvements to uTP and stability fixes |
Which bug? Are you saying that bug is related to enabling WAL, or just that dealing with it was a higher priority? |
It isn't related to WAL I was just talking about things I seen well benchmarking, the error is not related to enabling WAL mode and happening either way |
@carver ready for a review |
I was referring to running my benchmark I seen some error's Kim was telling me about, they were occurring on Trin master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks good. And nice addition to set synchronous mode to normal, now that that's safe to crashes and power failures.
What was wrong?
I ran #1660 without profiling
Before using WAL
INFO trin_bench: Finished gossiping blocks in 16m 11s, with 270336 offers
After enabling WAL
INFO trin_bench: Finished gossiping blocks in 11m 40s, with 270336 offers
I am testing with era1 files 1000 to 1010
How was it fixed?
So after enabling WAL the benchmark finish 1.39 times faster or enabling WAL resulted in approximately a 27.91% reduction in time