-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tempfile and uuid version due to including breaking change in getrandom #1669
Conversation
fc3fce6
to
b37e62c
Compare
I'm still getting the same error which this fix when I try to run a cross-compile locally with: env PROFILE=release make build-x86_64-unknown-linux-gnu
|
My error was because I tried making the change locally, which didn't include the fact that this PR explicitly downgrades other updates that happened in the Cargo.lock in the previous commit. After checking out directly to this commit, the configuration warning from |
Unfortunately, the pin didn't actually keep it from upgrading in a cargo update. So it's still something we'll have to watch for on the weekly update. Maybe we can fix with a pin of r2d2_sqlite?
|
I will try using a patch instead |
https://github.com/uuid-rs/uuid/releases/tag/1.13.0 |
So I think pinning uuid might do it. I'm trying |
ok I updated the PR to do that |
It didn't work for me. A |
same |
@carver what do you think of doing
for the time being up to you |
Taking a look... I'm okay with the approach, just want to make sure it works as planned |
Yeah, I'm good with this. In fact, I think we should revert the tempfile pin and patch it the same way. |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 when CI is green
What was wrong?
tempfile 3.16.0 uses getrandom 3 which is a breaking change, which was breaking our deployment script
How was it fixed?
fix tempfile to 3.15