Remove cli, fix windows compilation, move grafana create to TrinConfig, update trin-types to use clap#736
Conversation
c3ffd5b to
6748c6b
Compare
trin-types to use claptrin-types to use clap
4d3e4c0 to
67937f6
Compare
67937f6 to
9a1c951
Compare
|
I would like to see this split into separate PRs. Reading the PR title suggests that this should be at least 3 separate PRs. We want to do this because it is a lot easier for reviewers to spot any issues when the PR length is shorter and when it relates only to a single context. Sometimes of course, this is not possible because a single feature requires changes all over the place but in this case I clearly see 3 different contexts: 1. |
if moving grafana is seperate from clap grafana won't work till that is in then. I will see what I can do |
|
|
|
The PR has been split into 5 smaller PR's |
What was wrong?
fixes #573 (
trin-cliremoval as talked about in the meeting 5/11/2023)fixes Trin so that it can compile to windows
supercedes #698 (structout to clap conversion for trin-types)
updates/makes a few fixes to the trin book for grafana setup
How was it fixed?
trin-clitrin-clitrin-cli, move Create Grafana dashboard to TrinConfig (as discussed in the meeting 5/11/2023), updatetrin-typesfrom structopt to clapI updated structopt to clap since it was more work to keep structopt then just use clap, there is a WIP PR for it but it has been stalled for 2 weeks now of lack of development
To-Do