implement 2^63-1 check

ethereumjs · Dec 22, 2024 · 1b43fc1 · 1b43fc1
1 parent 1c09746
commit 1b43fc1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/tx/src/features/util.ts b/packages/tx/src/features/util.ts
@@ -2,6 +2,7 @@ import { Common, Mainnet } from '@ethereumjs/common'
 import {
   Address,
   MAX_INTEGER,
+  MAX_UINT63,
   MAX_UINT64,
   bigIntToHex,
   bytesToBigInt,
@@ -32,6 +33,18 @@ export function valueBoundaryCheck(
 ) {
   for (const [key, value] of Object.entries(values)) {
     switch (bits) {
+      case 63:
+        if (cannotEqual) {
+          if (value !== undefined && value >= MAX_UINT63) {
+            // TODO: error msgs got raised to a error string handler first, now throws "generic" error
+            throw new Error(`${key} cannot equal or exceed MAX_UINT63 (2^63-1), given ${value}`)
+          }
+        } else {
+          if (value !== undefined && value > MAX_UINT63) {
+            throw new Error(`${key} cannot exceed MAX_UINT63 (2^63-1), given ${value}`)
+          }
+        }
+        break
       case 64:
         if (cannotEqual) {
           if (value !== undefined && value >= MAX_UINT64) {

diff --git a/packages/util/src/constants.ts b/packages/util/src/constants.ts
@@ -8,6 +8,11 @@ import { hexToBytes } from './bytes.js'
  */
 export const MAX_UINT64 = BigInt('0xffffffffffffffff')
 
+/**
+ * 2^63-1
+ */
+export const MAX_UINT63 = BigInt(2) ** BigInt(63) - BigInt(1)
+
 /**
  * The max integer that the evm can handle (2^256-1)
  */