Skip to content

Commit

Permalink
tx: remove v==0 check which always defaults to the default common
Browse files Browse the repository at this point in the history
  • Loading branch information
jochem-brouwer authored May 31, 2022
1 parent a74572e commit 5f6bcc4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/tx/src/legacyTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,6 @@ export default class Transaction extends BaseTransaction<Transaction> {
// No unsigned tx and EIP-155 activated and chain ID included
if (
v !== undefined &&
!v.eqn(0) && // TODO fixme -> why overwrite/return default common when `v` is set to 0?
(!common || common.gteHardfork('spuriousDragon')) &&
!v.eqn(27) &&
!v.eqn(28)
Expand Down

0 comments on commit 5f6bcc4

Please sign in to comment.