vm: reintroduce modifyAccountFields #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
i am seeing this error in I think this issue is solved most recently by #1741 on master but it hasn't made it to develop yet. if after develop is updated it's still failing i'll look into it, but it seems fine on master. |
emersonmacro
approved these changes
Mar 4, 2022
|
great, thank you! will merge. @holgerd77 let me know if you'd like me to try the next develop rebase round (along with some specific instructions on your best way to go about it) |
holgerd77
reviewed
Mar 5, 2022
| account.stateRoot = accountFields.stateRoot ?? account.stateRoot | ||
| account.codeHash = accountFields.codeHash ?? account.codeHash | ||
| await this.putAccount(address, account) | ||
| } |
There was a problem hiding this comment.
This can be placed in the BaseStateManager if I am not mistaken.
There was a problem hiding this comment.
Ooh ok, sure, I can move it
There was a problem hiding this comment.
Thanks! 😄
Doing the develop rebase (test) right now.
holgerd77
pushed a commit
that referenced
this pull request
Mar 5, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
51 tasks
holgerd77
pushed a commit
that referenced
this pull request
Mar 24, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
holgerd77
pushed a commit
that referenced
this pull request
Apr 5, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
holgerd77
pushed a commit
that referenced
this pull request
Apr 7, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
g11tech
pushed a commit
that referenced
this pull request
Apr 29, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
holgerd77
pushed a commit
that referenced
this pull request
May 4, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
g11tech
pushed a commit
that referenced
this pull request
Jun 2, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
g11tech
pushed a commit
that referenced
this pull request
Jun 3, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
holgerd77
pushed a commit
that referenced
this pull request
Jun 8, 2022
* add modifyAccountFields method and tests * use new method in eei * update usage in various tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces @emersonmacro's #1369 on the
developbranch, since we had accidentally introduced a breaking change in the stateManager interface on master. This led to issues with hardhat's custom statemanager implementation not having the method. We reversed the work on master in #1390, and this PR now reintroduces it ondevelopas part of v6 breaking changes release (#1717)