Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: restrict PrefixedHexString types #3510

Merged
merged 3 commits into from
Jul 17, 2024
Merged

refactor: restrict PrefixedHexString types #3510

merged 3 commits into from
Jul 17, 2024

Conversation

gabrocheleau
Copy link
Contributor

This PR addresses one of the points from #3216, namely:

  • Go through the bytes module, and related functions that accept both PrefixedHexString | string as types, and restrict the type to only accept PrefixedHexString.

@gabrocheleau gabrocheleau marked this pull request as draft July 17, 2024 00:50
@gabrocheleau gabrocheleau marked this pull request as ready for review July 17, 2024 01:16
@gabrocheleau gabrocheleau mentioned this pull request Jul 17, 2024
Open
21 tasks
holgerd77
holgerd77 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🙂

@holgerd77 holgerd77 merged commit 6d83e3b into master Jul 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
breaking package: monorepo package: util type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @holgerd77