New utility methods for Common (loosely connected to Eth64 implementation) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 84.32% 84.46% +0.13%
==========================================
Files 17 17
Lines 1231 1242 +11
Branches 246 247 +1
==========================================
+ Hits 1038 1049 +11
Misses 125 125
Partials 68 68
Continue to review full report at Codecov.
|
holgerd77
force-pushed
the
add-next-fork-method-to-common
branch
from
1177ae4 to
f316dab
Compare
|
These block tests sometimes seem to timeout. I also had this on some other PR. If you re-run the CI there's a chance it'll pass. |
holgerd77
force-pushed
the
add-next-fork-method-to-common
branch
from
f316dab to
9d3271f
Compare
…hardforkForForkHash and associated tests
holgerd77
force-pushed
the
add-next-fork-method-to-common
branch
from
9d3271f to
f0e547d
Compare
jochem-brouwer
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ethereumjs/ethereumjs-devp2p#82
This PR adds the following methods to the
Commonlibrary together with associated tests:nextHardforkBlock()- Returns the next HF block for a HF provided or setisNextHardforkBlock()- Some convenience additional utility method, matching the existinghardforkBlock()/isHardforkBlock()method setuphardforkForForkHash()- Returns the data available for a HF given a specific forkHashAll functions are triggered by needs of the Eth64 implementation, but will likely - especially the first two next-HF-block functions also be useful in other contexts, e.g. for switching the HF setting on the client along block download.