an adapter contract to support withdrawal from weETH #287
Conversation
seongyun-ko
changed the title
add max withdrawal size
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| _requireNotPaused(); | ||
| _; | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Missing Conversion Function Causes Compilation Errors
The WeETHWithdrawAdapter contract implements IWeETHWithdrawAdapter but is missing the getEETHByWeETH function declared in the interface. This causes compilation errors and leaves a gap in the public interface, as users might expect this function for conversion rate calculations.
| uint256 eETHAmount = weETH.unwrap(weETHAmount); | ||
|
|
||
| // Approve eETH to be spent by LiquidityPool | ||
| IERC20(address(eETH)).safeApprove(address(liquidityPool), eETHAmount); |
There was a problem hiding this comment.
Bug: Non-Zero Allowance Blocks Safe Approve
The safeApprove call for eETH to the liquidityPool in requestWithdraw can revert if an existing allowance is not zero. This behavior, inherent to SafeERC20.safeApprove, causes subsequent calls to requestWithdraw to fail.
| uint256 requestId = nextRequestId++; | ||
| uint32 feeGwei = uint32(fee / 1 gwei); | ||
|
|
||
| if(amountOfEEth > maxWithdrawalAmount) revert TooLargeWithdrawalAmount(); |
There was a problem hiding this comment.
Bug: Withdrawal Functionality Initially Disabled
The maxWithdrawalAmount variable defaults to 0 and lacks initialization. This blocks all withdrawal requests in requestWithdraw immediately after deployment, leading to a denial of service until an admin sets a non-zero value.
3 participants
Note
Adds a weETH withdrawal adapter (incl. permit flow) and enforces an admin-configurable max withdrawal amount in WithdrawRequestNFT.
src/WeETHWithdrawAdapter.sol(new):weETHby unwrapping toeETHand creating requests viaLiquidityPool.requestWithdrawWithPermit.RoleRegistry, emits pause events; exposesgetImplementation.src/interfaces/IWeETHWithdrawAdapter.sol(new interface):requestWithdraw,requestWithdrawWithPermit(withPermitInput),getEETHByWeETH, andWithdrawRequestedevent.maxWithdrawalAmountwithsetMaxWithdrawalAmount(admin-only).requestWithdrawto revert withTooLargeWithdrawalAmountwhen exceeding the cap.Written by Cursor Bugbot for commit 63ee206. This will update automatically on new commits. Configure here.