Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): custom network support #49

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Conversation

mattevans
Copy link
Member

@mattevans mattevans commented Jan 16, 2025

  • Updates config and install wizard screens to allow config of custom docker network if runMethod == docker.
  • Updates existing validation to ensure beacon node health check only for host level nodes.
  • Fixes issue where you could not 'Go Back' from the install wizard beacon config view.
  • Updates compose file to handle custom network
  • Creates appropriate default network on docker.Start() and subsequently tears it down on Stop().

Screenshot 2025-01-16 at 13 07 46

How to test

There is integrations tests for this, using test containers, but to manually test.

  1. Spin up kurtosis.
  2. Configure dockerNetwork as per kurtosis network name (usually your enclave name, eg: kt-matty-testnet).
  3. Configure your beaconNodeAddress as the CL node container name (eg: http://cl-1-lighthouse-nethermind--6cbd17feef8c43488af7582614edbf54:4000). Use the containers exposed port, now we're using a custom docker network.
  4. Profit.

@mattevans mattevans changed the title Feat/docker network support feat(docker): custom network support Jan 16, 2025
@mattevans mattevans self-assigned this Jan 16, 2025
* master:
  chore: update contributoor to v0.0.39
@mattevans mattevans merged commit 505b9bd into master Jan 16, 2025
7 checks passed
@mattevans mattevans deleted the feat/docker-network-support branch January 16, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant