Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RELATIVE-OID #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for RELATIVE-OID #196

wants to merge 2 commits into from

Conversation

russhousley
Copy link

Add support for RELATIVE-OID.

@codecov-commenter
Copy link

Codecov Report

Merging #196 into master will decrease coverage by 0.57%.
The diff coverage is 65.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   86.65%   86.07%   -0.58%     
==========================================
  Files          26       26              
  Lines        4600     4732     +132     
==========================================
+ Hits         3986     4073      +87     
- Misses        614      659      +45     
Impacted Files Coverage Δ
pyasn1/codec/native/decoder.py 86.48% <ø> (ø)
pyasn1/codec/ber/decoder.py 84.26% <50.00%> (-2.20%) ⬇️
pyasn1/codec/native/encoder.py 84.46% <66.66%> (-0.54%) ⬇️
pyasn1/type/univ.py 84.50% <78.72%> (-0.22%) ⬇️
pyasn1/codec/ber/encoder.py 89.18% <88.88%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8f1a7...c3cbdbb. Read the comment docs.

Copy link

@scy scy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RelativeOIDPayloadDecoder appears twice in the source.

pyasn1/codec/ber/decoder.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #196 into master will decrease coverage by 0.05%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   86.65%   86.59%   -0.06%     
==========================================
  Files          26       26              
  Lines        4600     4700     +100     
==========================================
+ Hits         3986     4070      +84     
- Misses        614      630      +16     
Impacted Files Coverage Δ
pyasn1/codec/native/decoder.py 86.48% <ø> (ø)
pyasn1/codec/native/encoder.py 84.46% <66.66%> (-0.54%) ⬇️
pyasn1/type/univ.py 84.50% <78.72%> (-0.22%) ⬇️
pyasn1/codec/ber/encoder.py 89.18% <88.88%> (-0.02%) ⬇️
pyasn1/codec/ber/decoder.py 86.58% <90.62%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8f1a7...cfb6d07. Read the comment docs.

Lostboi pushed a commit to inexio/pyasn1 that referenced this pull request Dec 21, 2020
@Lostboi
Copy link

Lostboi commented Dec 21, 2020

Hey @russhousley

i merged the pull request on inexio/pyasn1 the fork where we try to maintain the pyasn1 for the community as much as we can, so as you got any questions write me or open an issue on this forked Repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants