modify resolv-conf resource #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adsr
approved these changes
Aug 21, 2024
ericnorris
added a commit
that referenced
this pull request
Nov 11, 2024
ericnorris
added a commit
that referenced
this pull request
Nov 11, 2024
Per @kornface13, this is no longer necessary - reverting so I can pull in #28. This reverts commit ec07a0e, reversing changes made to b774201.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the resolve.conf template resource so that it removes the systemd-resolve managed symlink and creates a regular file.
Context / Why are we making this change?
When chef attempts to update a template that's symlinked, it will update the source file instead of the file you intend to update.
On Ubuntu, /etc/resolv.conf is symlinked to /run/systemd/resolve/stub-resolv.conf and managed by systemd-resolved.
Resolve.conf and systemd-resovled both attempt to update the same file, so it's safe to assume you shouldn't ever be using both at the same time. If you use resolve.conf, we want to remove this symlink and treat resolv.conf as a normal file.
Both options (
force_unlinkandmanage_symlink_source) seem to be needed based on this bug report: chef/chef#4992Testing and QA Plan
Images build and function correctly with these additional options added to the template resource.