Skip to content

Commit

Permalink
Neuter the PlayerOptions Practice Mode option
Browse files Browse the repository at this point in the history
basically this causes some issues
these changes stop it from being relevant at all (not considered in copies, saves, loads)
it will still appear in mod strings
  • Loading branch information
poco0317 committed Nov 24, 2019
1 parent 603c0e2 commit cc765fd
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/Etterna/Models/Misc/PlayerOptions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ PlayerOptions::Approach(const PlayerOptions& other, float fDeltaSeconds)
for (int i = 0; i < NUM_TRANSFORMS; i++)
DO_COPY(m_bTransforms[i]);
DO_COPY(m_bMuteOnError);
DO_COPY(m_bPractice);
DO_COPY(m_FailType);
DO_COPY(m_MinTNSToHideNotes);
DO_COPY(m_sNoteSkin);
Expand Down Expand Up @@ -994,7 +993,6 @@ PlayerOptions::operator==(const PlayerOptions& other) const
COMPARE(m_FailType);
COMPARE(m_MinTNSToHideNotes);
COMPARE(m_bMuteOnError);
COMPARE(m_bPractice);
COMPARE(m_fDark);
COMPARE(m_fBlind);
COMPARE(m_fCover);
Expand Down Expand Up @@ -1046,7 +1044,6 @@ PlayerOptions::operator=(PlayerOptions const& other)
CPY(m_FailType);
CPY(m_MinTNSToHideNotes);
CPY(m_bMuteOnError);
CPY(m_bPractice);
CPY_SPEED(fDark);
CPY_SPEED(fBlind);
CPY_SPEED(fCover);
Expand Down Expand Up @@ -1223,7 +1220,6 @@ PlayerOptions::GetSavedPrefsString() const
SAVE(m_bTransforms[TRANSFORM_NOLIFTS]);
SAVE(m_bTransforms[TRANSFORM_NOFAKES]);
SAVE(m_bMuteOnError);
SAVE(m_bPractice);
SAVE(m_sNoteSkin);
SAVE(m_fAppearances[APPEARANCE_HIDDEN]);
SAVE(m_fAppearances[APPEARANCE_HIDDEN_OFFSET]);
Expand Down

0 comments on commit cc765fd

Please sign in to comment.