Refactor Gameplay, Replays, and Practice #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more: remove a variable referring to multiplayer that is not really useful anywhere in the game's current state and better used in another way shaved so much stuff off of gameplay I gained 200 fps (on top of about 1200 fps average)
this mysterious (but logical) change nets me another 200 fps in gameplay when not syncing or using autoplay
i dont have a clue how it was compiling before
|
PlayerInfo is its own file Practice/Replay specific functions are part of their own class
replace the gameplay branch with a "solid" fallback
(just remove a dead function)
autoplay should properly disappear now
poco0317
force-pushed
the
gameplay_rewrite
branch
from
8a90fe2 to
2d4c1d8
Compare
poco0317
force-pushed
the
gameplay_rewrite
branch
from
2d4c1d8 to
1b7fb85
Compare
dont use a bunch of bools haha
and remove frets from the Player ?????
cant do that namespace thing from within the class sometimes i dont know how this happened
so Player derivatives can use them
during the process of building the internal representation of replay data for playback
this bug seems to be gone
annoying thing fixed for players ... just need to specify you use EffectUp and EffectDown instead of the arrows....
also applies to EWMA
Blind should only cause your gameplay to be "blind" as in "you have no reliable feedback" So only Judgments and Combo should be invisible. In addition, the color of the explosions, if applicable in the Noteskin, should be constantly Marvelous even on a tap release so feedback is even more useless.
poco0317
force-pushed
the
gameplay_rewrite
branch
from
a7102a9 to
7d80865
Compare
to save EO some trouble with players using the replay feature more often now hopefully
more consistent behavior, less confusion, etc etc
these cause the song preview to reset when you do kind of random things and just making them all consistent would be good this code is getting very very spaghetti and needs to be rewritten or put into functions
unused, unneeded
this function just plays the sample music for the song but lets it run the full length.
these functions have to be called in a strict order for proper calculations
it wasnt updating immediately before, only on profile reload should be good now
tested with 5 profiles and with no profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up a little early to monitor progress and let people piss me off by commenting on my code before it's done
Handles #463
(by extension handles #367 #461 #473 #474 #476 #491 #495 #496 #578
#582#583 #588#593#595#599#601 #616)Handles #497 #444 #644