Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve event timestamps in X11 input driver #643

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

192314
Copy link
Contributor

@192314 192314 commented Oct 14, 2019

Fix for #642 .

Analogous to this pull request:

The X11 XKeyEvent structure (and others) include a timestamp field, with 1ms resolution.
This was previously ignored causing the input timestamps to be set to the middle of each frame.
If the timestamps are passed through then the event timestamps are not coupled to the framerate and the polling issues are resolved.

@poco0317
Copy link
Member

Looks fine. This doesn't concern me particularly, but I just want to point out that the commit listed isn't under your name.

Don't really have a way to test this other than confirming build is fine and having testers check it out.

@nico-abram
Copy link
Member

nico-abram commented Oct 14, 2019

Seems good to me too (Just from skimming it, no testing either)

Should crediting also be done in the commit message to the PR you linked in the message here?

@192314
Copy link
Contributor Author

192314 commented Oct 14, 2019

Should crediting also be done in the commit message to the PR you linked in the message here?

Sure, I just updated the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants