Feat/same device #13
Merged
Feat/same device #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
otsolka
approved these changes
Sep 23, 2024
SmirlakisParis
merged commit 49facaa
into
eu-digital-identity-wallet:main
2 of 3 checks passed
| const deviceType = useAppStore((state) => state.deviceType); | ||
|
|
||
| const onSubmit = async (data: BookingDto) => { | ||
| console.log(data); | ||
| await createBookingAsync(data); | ||
| }; | ||
|
|
||
| // Watch for changes in bookingCreateRes | ||
| useEffect(() => { |
There was a problem hiding this comment.
This can be simplified as:
useEffect(() => {
if (bookingCreateRes?.url) {
deviceType === 'desktop' ? changeModalStatus(ModalStatus.OPEN) : (window.location.href = bookingCreateRes.url);
}
}, [bookingCreateRes?.url, deviceType, changeModalStatus]);
| @@ -24,7 +24,7 @@ const ConfirmationDetails = ({ | |||
| reservationDate, | |||
| } = details; | |||
| const { isLoading, issueConfirmationAsync } = useBookingStore(); | |||
|
|
|||
| console.log(id); | |||
There was a problem hiding this comment.
Forgot this console.log?
| router.push(PATHS.confirmation(bookingId)); // Navigate to confirmation page | ||
| } | ||
|
|
||
| // Timeout logic to stop polling after 30 seconds | ||
| const timeout = setTimeout(() => { | ||
| stopPolling(); // Stop polling after 30 seconds | ||
| }, 30000); | ||
| }, 60000); |
There was a problem hiding this comment.
Maybe this should be an env var
| @@ -36,14 +36,15 @@ export const useBookingVerify = () => { | |||
| const { data, error } = useSWR( | |||
| bookingId, | |||
| fetcher, | |||
| { refreshInterval: polling ? 1000 : 0 } // Poll every second if polling is true | |||
| { refreshInterval: polling ? 3000 : 0 } // Poll every second if polling is true | |||
There was a problem hiding this comment.
Maybe this should be an env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue verification for same device